bboard

while (x == y)
{   something();
    somethingelse();
    //...
    if (x < 0)
    {   printf("Negative");
        negative(x);
    }
    else
    {   printf("Non-negative");
        nonnegative(x);
    }
}
finalthing();

int some_function(int n)
{   //documentation goes here
    do_something(n);
    if (n > 12)
    {
        printf("invalid month");
    }
    return n-1;
}

orders:
- name: Apples
  price: 1.5
- name: Onions
  price: 2
"2d_identity_matrix":  # quotes optional
- - 1

orders:
-
  name: Apples
  price: 1.5
-
  name: Onions
  price: 2
"2d_identity_matrix":
-
  - 1

orders:
  -
    name: Apples
    price: 1.5
  -
    name: Onions
    price: 2
"2d_identity_matrix":
  -
    - 1

Posted by sureanem

So why isn't it more popular? When I show people it, the reactions are either "that's absolutely disgusting, never show me it again," or "that's amazing, why haven't I heard of this before?". But nobody seems to be able to explain why they hate it, other than that it's unfamiliar.

int foo(int moo) {
     return moo + 1;
}

if (a + b = c) {
     // do it!
     doIt();
}

public static final int SOME_CONSTS = {0, 1, 2, 4, 8, 16, 32}

Posted by tomman
EXCEPTION: Constant arrays - those are always a one-liner (if possible):

public static final int SOME_CONSTS = {0, 1, 2, 4, 8, 16, 32}

const
        Shapes : array[0..(8 * 3 * 7)-1] of char = (
                '████████' +
                '        ' +
                '        ' +
                '██████  ' +
                '  ██    ' +
                '        ' +
                '████    ' +
                '  ████  ' +
                '        ' +
                '  ████  ' +
                '████    ' +
                '        ' +
                '████    ' +
                '████    ' +
                '        ' +
                '██      ' +
                '██████  ' +
                '        ' +
                '    ██  ' +
                '██████  ' +
                '        ');

Posted by tomman
I've never liked opening braces just before sentences. And I'm on the opinion that the closing brace should go alone on its own line.

I'll stick to the good ol' "explain what you're about to do", that is, the opening brace on the same line as the structure declaration:

Posted by jimbo1qaz
You lose the ability to use a text editor or IDE to comment out the first line (or swap the first line in an indented block with other lines).

for (;;)
{   a();
    b();
    c();
}

for (;;)
{   //a();
    b();
    c();
}

Posted by sureanem

Posted by tomman
I've never liked opening braces just before sentences. And I'm on the opinion that the closing brace should go alone on its own line.

I'll stick to the good ol' "explain what you're about to do", that is, the opening brace on the same line as the structure declaration:

How do you find out which block is which if the braces don't line up? With multiple levels of nesting, that gets ugly fast.

Posted by sureanem
How do you find out which block is which if the braces don't line up? With multiple levels of nesting, that gets ugly fast.

for (x = 1; x < 10; x++) {
    if (x % 2 == 0) {
        printf("Even!");
    } else {
        printf("Odd!");
    }
}

Posted by tomman

It's called "use a competent editor/IDE that can highlight matching braces".

This sadly excludes most (if not all?) CLI-based editors and Notepad, but that's fine as I don't use those for coding.

Posted by Screwtape

Indenting, obviously:

for (x = 1; x < 10; x++) {
    if (x % 2 == 0) {
        printf("Even!");
    } else {
        printf("Odd!");
    }
}

If you tell me you can look up from "}" to find the aligned "{", but can't look up from "}" to find any other aligned text, I'm going to be very doubtful.

if (x < foo(y, z))
    haha = bar[4] + 5;
else {
    while (z) {
        haha += foo(z, z);
        z--;
    }
    return ++x + bar();
}

if (data != NULL && res > 0) {
    if (!JS_DefineProperty(cx, o, "data", STRING_TO_JSVAL(JS_NewStringCopyN(cx, data, res)), NULL, NULL, JSPROP_ENUMERATE)) {
        QUEUE_EXCEPTION("Internal error!");
        goto err;
    }
    PQfreemem(data);
}
else if (!JS_DefineProperty(cx, o, "data", OBJECT_TO_JSVAL(NULL), NULL, NULL, JSPROP_ENUMERATE)) {
    QUEUE_EXCEPTION("Internal error!");
    goto err;
}

THAT SAID, much like "which font is the most readable", the biggest factor of all is what you're already used to. If you've spent twenty years finding blocks by looking for isolated "{" and "}" characters while ignoring all the text between them, finding blocks by any other pattern is going to be more effort and feel "wrong".

One of the happiest discoveries I've made while learning Rust is the rustfmt command for automatically formatting code. While automatic formatting can never be quite as nice as manual formatting, it's great to be able to type in any old thing, hit "save" and watch it magically become neat and tidy. Less dramatically but more significantly, I don't waste ten minutes trying to reformat something "just right" because it'll snap right back afterwards. Of course, it helps that the Standard Rust Style is pretty close to my preferred style anyway, but if more people used auto-formatting there'd be fewer threads like this one. ;)

Posted by wareya
The standard rust style is wrong because it doesn't use allman braces. Fight me.

Posted by Screwtape
> Vim supports it, and presumably emacs too. Which CLI-based editors don't, you mean?

nano doesn't highlight matching brackets, although it does have a "jump to matching bracket" command.

I know this because I was going to reply to tomman with something like "even nano highlights matching brackets!" and then decided to actually fact-check myself.