heyheyhey |
Posted on 21-11-18, 03:52
|
Post: #3 of 4
Since: 11-12-21 Last post: 1099 days Last view: 1070 days |
Is this going to be a problem? |
heyheyhey |
Posted on 21-11-18, 11:36
|
Post: #4 of 4
Since: 11-12-21 Last post: 1099 days Last view: 1070 days |
Well everything seems to work. This is the first time I ever compiled bsnes, or any other emulator for that matter. I have been using higan and bsnes for years, and every version would have a pixel of garbage on either side of the screen when using Direct3d, but for some reason simply compiling it myself fixed that. The only change I made was to the overscan mask value in viewport.cpp from 224 to 216 so that integer scaling could now fill a 1080p display from top to bottom. My next step was going to be to add 1 pixel of horizontal overscan mask to hide that garbage but no need to now. Had no idea just compiling something on your machine could clear up bugs like that. |
wertigon |
Posted on 21-11-18, 21:38
|
Post: #167 of 205
Since: 11-24-18 Last post: 155 days Last view: 27 days |
Just an FYI; that warning should get fixed, but warnings in general are nothing to worry about for the end user. As long as it provides a binary, it should be fine. Look at compiler warnings as the compiler going "Oh, hey! In this line here, you tried to do X! Looking at the context and the code, it appears what you want to do is Y. I therefore helpfully did Y instead, and here is a message telling you I did Y. Have a Nice Day(tm)!" |