MassHesteria |
Posted on 18-12-22, 15:20 (revision 1)
|
Post: #1 of 7
Since: 12-22-18 Last post: 1970 days Last view: 1969 days |
The Windows implementation of KeyDown processing on the LineEdit widget generates an Activate signal when any key is pressed, but I think it should only generate the signal when the Enter/Return key is pressed. This causes Managed States in BSNES 106.68 to be unusable. I have not tested this in Higan yet. I made the following changes locally to resolve the issue: FILE: higan/windows/widget/line-edit.cpp OLD:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> { if(msg == WM_KEYDOWN) { self().doActivate(); } NEW:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> {
if(msg == WM_KEYDOWN && wparam == VK_RETURN) { self().doActivate(); } |
Kawaoneechan |
Posted on 18-12-22, 15:20
|
Coke™ Addict
Post: #113 of 599 Since: 10-29-18 Last post: 134 days Last view: 3 hours |
Gave your post a spit-shine, cos I'm like that. |
MassHesteria |
Posted on 18-12-22, 17:31
|
Post: #2 of 7
Since: 12-22-18 Last post: 1970 days Last view: 1969 days |
Thanks! Couldn't remember the "source" tag earlier. I'm gonna post another finding later and will use the tags to make it look purty. What was the trick to get "hiro" to look good on the subject? |
Kawaoneechan |
Posted on 18-12-22, 17:40
|
May contain nuts
Post: #114 of 599 Since: 10-29-18 Last post: 134 days Last view: 3 hours |
[tags] in the thread title. |
Near |
Posted on 18-12-27, 00:24
|
Burned-out Genius Developer
Post: #2 of 51 Since: 10-30-18 Last post: 1358 days Last view: 1281 days |
Fixed, thank you! |