0 users browsing Projects. | 1 guest  
    Main » Projects » LineEdit widget on Windows bug hiro
    Pages: 1
    Posted on 18-12-22, 15:20 (revision 1)
    Post: #1 of 7
    Since: 12-22-18

    Last post: 904 days
    Last view: 903 days
    The Windows implementation of KeyDown processing on the LineEdit widget generates an Activate signal when any key is pressed, but I think it should only generate the signal when the Enter/Return key is pressed. This causes Managed States in BSNES 106.68 to be unusable. I have not tested this in Higan yet. I made the following changes locally to resolve the issue:

    FILE:
    higan/windows/widget/line-edit.cpp

    OLD:
    auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> {
      if(msg == WM_KEYDOWN) {
        self().doActivate();
      }

    NEW:
    auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> {
      if(msg == WM_KEYDOWN && wparam == VK_RETURN) {
        self().doActivate();
      }
    Posted on 18-12-22, 15:20
    Hard to label!

    Post: #113 of 567
    Since: 10-29-18

    Last post: 12 days
    Last view: 14 min.
    Gave your post a spit-shine, cos I'm like that.
    Posted on 18-12-22, 17:31
    Post: #2 of 7
    Since: 12-22-18

    Last post: 904 days
    Last view: 903 days
    Thanks! Couldn't remember the "source" tag earlier. I'm gonna post another finding later and will use the tags to make it look purty. What was the trick to get "hiro" to look good on the subject?
    Posted on 18-12-22, 17:40
    Lonely Man

    Post: #114 of 567
    Since: 10-29-18

    Last post: 12 days
    Last view: 14 min.
    [tags] in the thread title.
    Posted on 18-12-27, 00:24
    Burned-out Genius Developer
    Post: #2 of 51
    Since: 10-30-18

    Last post: 291 days
    Last view: 214 days
    Fixed, thank you!
    Pages: 1
      Main » Projects » LineEdit widget on Windows bug hiro
      [Your ad here? Why not!]