code block| Thread review | |
|---|---|
| desudesu |
The post help toolbar doesn't respect themes properly for whatever reason. It also looks weird because it's not aligned with the rest of the tables nor is there a space between it and the thread review. online.php also doesn't respect the user's choice of date/time format (always using d-m-y H:i:s, which is even stranger considering the rest of the board exclusively uses m-d-y h:i A unless the user chose to override it, including when you register an account for the first time.) The FAQ still mentions 'new reply fields' which aren't there anymore. If I remember correctly, recalculating the board statistics resets the last post date as though >>6507 wasn't in the code, which is interesting. |
| desudesu |
Posted by Nicholas Steel NO WAY, I CAN'T BELIEVE THIS! |
| CaptainJistuce |
Posted by desudesu I don't get it. You said the same thing twice! |
| Nicholas Steel |
Posted by desudesu Or Kawa secretly snuck in a change while you weren't looking! |
| desudesu | Wasn't the last time I looked. Or maybe I'm just blind. |
| Kawaoneechan |
Posted by desudesuBut it is? |
| desudesu |
True. I've looked at ABXD's code though, and more specifically both the 2.x and 3.x lines. I wouldn't call it bad, but it's not the best thing in the world either. That said I expect this fork of it has a lot more under the hood changes regarding the way the code itself is written and structured that isn't obvious. I remember turning E_NOTICE on once when messing with an ABXD 2 board's code and the amount of "undefined index/variable" notices was... rather high to say the least. (3.0 is even worse in that regard, and is in quite a few ways a step back due to it basically just being an early alpha that was pushed out and "done" with). Oh, unrelatedly, StapleButter should be Arisotura in the board footer. |
| CaptainJistuce |
Posted by desudesuIf it ain't broke... |
| desudesu |
Very minor nag but wouldn't the breadcrumbs and header titles be better swapped around in the settings file? Even in phpBB I think the default breadcrumbs title is 'Forum index' :p Posted by Kawa I mean, a ten years old codebase is probably not ideal, meow~ pet |
| Nicholas Steel | You must've hated my posts when I was new to this board. |
| Kawaoneechan | It's just, I try to limit how much I have to work with PHP so I'd rather not mess with the board code too much 😸 |
| tomman |
Yeah, usually my edits are quick spelling corrections and stuff. Very rarely, I do larger edits (and only when the last post on a thread is mine, so to avoid double posts (although I've seen other board software which can auto-merge posts on said cases, usually at the discretion of the mods. I agree that there are good reasons to preserve edit history (even if not accessible to the actual posters themselves), but in my case, feel free to nuke my edit story then. |
| Kawaoneechan |
Possible? Certainly. I'd sooner and rather implement a button that nukes your edit history. Yours, specifically. If I was feeling particularly adventurous I might do a thing where if the changes amount to a dozen or so characters, it simply doesn't save it as a revision at all. But more to the point... yeah, it is meant to do that. It's even got a comment:
//Update thread lastpostdate if we edited the last post if($wasLastPost) { //SNIP } * Kawa comments out that block |
| tomman |
Posted by Kawa Wait, what?! So, six edits to correct, say, a couple words on a 1000-word wall-o-text creates... six wall-o-texts on the database!? Man, and I thought I had it hard with at $FORMER_JOB with those historic checkpoints (which is basically the same junk, but more fragile because raisins). Wonder if it is possible to save an actual diff instead of a whole copy on each edit. |
| Kawaoneechan |
Yeah I think it is in fact meant to do that. I'd prefer you didn't since editing a reply over and over puts yet another copy of the whole freakin' thing in the DB but yeah. |
| tomman |
So, I've noticed that when I modify a post (most likely the last reply on a thread which happens to be my post), it bumps the whole thread to the top, like I had posted a new reply! This is kinda weird. Is this by design? Like, I could force a thread to stay to the top by just editing a reply over and over, but most likely this is not international. |
| Kawaoneechan |
Ah yes. The internal search is staff-only and Chrome won't let me redirect to Google. Guess I'll have to make the internal search respect power levels. |
| Nicholas Steel | The search button at the top of this site only displays a Google Search though... no internal search. |
| Kawaoneechan | Yeah, Google search is broken. Internal still works though. |
| KoiMaxx |
Hi everyone, I was wondering if this were just me, but is the Search function on the fritz? I can't seem to search anything, can't even search if anybody's already mentioned that Search might not be working. Thanks :) |