| MassHesteria |
Posted on 18-12-22, 15:20 in LineEdit widget on Windows bug [hiro] (revision 1)
|
|
Post: #1 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
The Windows implementation of KeyDown processing on the LineEdit widget generates an Activate signal when any key is pressed, but I think it should only generate the signal when the Enter/Return key is pressed. This causes Managed States in BSNES 106.68 to be unusable. I have not tested this in Higan yet. I made the following changes locally to resolve the issue: FILE: higan/windows/widget/line-edit.cpp OLD:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> { if(msg == WM_KEYDOWN) { self().doActivate(); } NEW:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> {
if(msg == WM_KEYDOWN && wparam == VK_RETURN) { self().doActivate(); } |
| MassHesteria |
Posted on 18-12-22, 17:31 in LineEdit widget on Windows bug [hiro]
|
|
Post: #2 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
Thanks! Couldn't remember the "source" tag earlier. I'm gonna post another finding later and will use the tags to make it look purty. What was the trick to get "hiro" to look good on the subject? |
| MassHesteria |
Posted on 19-01-30, 11:58 in Couple Issues [bsnes]
|
|
Post: #4 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
I've been playing with BSNES v106r88 on Windows and observed two issues. I know there is a UI rework going on for higan at least, but I figured I would throw these out there just in case. 1) Defocus setting is not remembered when restarting BSNES. The correct value (Block, Allow, etc.) is written to the BML file, but the UI always uses the default. I tried pulling older revisions, and it seems that this one showed up in either r86 or r87. 2) Screenshots for save states have stopped working. These were working in an earlier WIP. Unfortunately I didn't notice the revision when they stopped working. As always, thanks for the hard work on a great set of emulators! |
| MassHesteria |
Posted on 19-04-30, 01:42 in Conflicted bsz files [bsnes]
|
|
Post: #5 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
I have been running the latest bsnes (v107.3 beta) and my Managed Save States keep disappearing from the State Manager. The bsz file that contains the associated states keeps getting renamed to from "rom_name.bsz" to "rom_name [conflicted #].bsz". The number (#) keeps incrementing. Mine is currently at 14. Any thoughts on what might be happening? |
| MassHesteria |
Posted on 19-04-30, 10:46 in Conflicted bsz files [bsnes]
|
|
Post: #6 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
They are! Maybe they shouldn't be... |
| MassHesteria |
Posted on 19-04-30, 10:59 in Conflicted bsz files [bsnes]
|
|
Post: #7 of 7
Since: 12-22-18 Last post: 2032 days Last view: 2031 days |
Yea, that's definitely it. Thanks! |
