code block
Thread review | |
---|---|
Near | Fixed, thank you! |
Kawaoneechan | [tags] in the thread title. |
MassHesteria | Thanks! Couldn't remember the "source" tag earlier. I'm gonna post another finding later and will use the tags to make it look purty. What was the trick to get "hiro" to look good on the subject? |
Kawaoneechan | Gave your post a spit-shine, cos I'm like that. |
MassHesteria |
The Windows implementation of KeyDown processing on the LineEdit widget generates an Activate signal when any key is pressed, but I think it should only generate the signal when the Enter/Return key is pressed. This causes Managed States in BSNES 106.68 to be unusable. I have not tested this in Higan yet. I made the following changes locally to resolve the issue: FILE: higan/windows/widget/line-edit.cpp OLD:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> { if(msg == WM_KEYDOWN) { self().doActivate(); } NEW:
auto pLineEdit::windowProc(HWND hwnd, UINT msg, WPARAM wparam, LPARAM lparam) -> maybe<LRESULT> {
if(msg == WM_KEYDOWN && wparam == VK_RETURN) { self().doActivate(); } |